Refactor: extract DIFF_ROUTES mapping from server.py#237
Open
Adeelp1 wants to merge 5 commits intoedgi-govdata-archiving:mainfrom
Open
Refactor: extract DIFF_ROUTES mapping from server.py#237Adeelp1 wants to merge 5 commits intoedgi-govdata-archiving:mainfrom
Adeelp1 wants to merge 5 commits intoedgi-govdata-archiving:mainfrom
Conversation
Contributor
Author
|
This PR is a follow-up to #226. Conflicts that appeared after the previous PR was merged into This continues the refactor by extracting DIFF_ROUTES into a |
Member
|
Hi @Adeelp1, sorry I have not been able to get to this. I’m at a conference this week, and will try and take a look this weekend or early next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract DIFF_ROUTES mapping from server.py into a dedicated
diff_routes module.
No functional changes. Improves separation of concerns and reduces
the size of server.py.
Follow-up to #226.
Related to #28.