fix(service): allow unnecessary_cast for eCAL 6.0/6.1.1 compatibility#105
Merged
Conversation
eCAL_eCallState_* constants are generated as u32 by bindgen against eCAL 6.0.x headers, making the 'as i32' casts required. In eCAL 6.1.1 bindgen generates them as i32, making the casts redundant and triggering clippy's unnecessary_cast lint. Suppress the lint with #[allow(clippy::unnecessary_cast)] on the From<i32> impl so the same code compiles cleanly against both eCAL versions.
There was a problem hiding this comment.
Pull request overview
This PR keeps rustecal-service building cleanly across eCAL 6.0.x and 6.1.1 by suppressing clippy::unnecessary_cast where bindgen emits differing integral types for the same eCAL constants.
Changes:
- Add
#[allow(clippy::unnecessary_cast)]to theimpl From<i32> for CallStateconversion to tolerate u32/i32 bindgen differences between eCAL versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eCAL_eCallState_* constants are generated as u32 by bindgen against eCAL 6.0.x headers, making the 'as i32' casts required. In eCAL 6.1.1 bindgen generates them as i32, making the casts redundant and triggering clippy's unnecessary_cast lint.
Suppress the lint with #[allow(clippy::unnecessary_cast)] on the From impl so the same code compiles cleanly against both eCAL versions.