Add configured labels to worker pods#216
Merged
mnonnenmacher merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
Sprig's `merge` mutates its destination in place. Passing `.Values.commonLabels` directly caused chart labels to be written back into the shared values map, polluting it for all subsequent template evaluations in the same render. Fix this by using `deepCopy` so `merge` operates on a throwaway copy. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
Automatically add the lables configured in `Values.commonLabels` and `Values.podLabels` to the worker pods created by the orchestrator. This requires converting the label maps into comma-separated strings of key-value pairs and passing them to the orchestrator via the worker specific environment variables. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
mnonnenmacher
force-pushed
the
worker-labels
branch
from
ecf3639 to
c39a507
Compare
sschuberth
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.