Add PR review norms for the mobile team#23
Open
shubham1g5 wants to merge 2 commits intomasterfrom
Open
Conversation
Added a reference to PR review norms in the mobile standards document.
shubham1g5
requested review from
OrangeAndGreen,
avazirna,
conroy-ricketts and
ctsims
Contributor
conroy-ricketts
left a comment
conroy-ricketts
left a comment
There was a problem hiding this comment.
Looks great! I just had one minor comment
| - **Repeated or inline logic** — copy-pasted blocks or complex lambdas that deserve a named method | ||
| - **Duplicate utilities** — if something already exists in the codebase, point it out | ||
| - **Null safety (`!!`)** — we use the fail-fast approach; removing `!!` without discussion should be flagged | ||
| - **TODO hygiene** — every TODO needs either a Jira ticket reference or a sentence explaining the deferral |
Contributor
There was a problem hiding this comment.
Think these norms should be developer-agnostic (i.e. they should 100% apply to open source developers as well). Can we remove the mention of Jira tickets here in favor of just "a sentence explaining the deferral"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds PR review norms for mobile PR reviews based on a team session
Changeset Category
This PR is streamlined for review in the following category