Skip to content

Drop overwritten key#6876

Merged
kaapstorm merged 1 commit intomasterfrom
nh/ksplice_namespace
May 8, 2026
Merged

Drop overwritten key#6876
kaapstorm merged 1 commit intomasterfrom
nh/ksplice_namespace

Conversation

@kaapstorm
Copy link
Copy Markdown
Contributor

secrets.yml gives two values for "legacy_namespace" for "KSPLICE_ACTIVATION_KEY". PyYAML overwrites the first value with the second value:

>>> import yaml
>>> secrets = """
- name: KSPLICE_ACTIVATION_KEY
  legacy_namespace: localsettings_private
  legacy_namespace: secrets
- name: MAPBOX_ACCESS_TOKEN
  legacy_namespace: localsettings_private
  default: ''
"""
>>> yaml.safe_load(secrets)
[{'name': 'KSPLICE_ACTIVATION_KEY',
  'legacy_namespace': 'secrets'},
 {'name': 'MAPBOX_ACCESS_TOKEN',
  'legacy_namespace': 'localsettings_private',
  'default': ''}]

This change just removes the first (unused) value.

@kaapstorm kaapstorm merged commit 04b6e44 into master May 8, 2026
7 checks passed
@kaapstorm kaapstorm deleted the nh/ksplice_namespace branch May 8, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants