Skip to content

fix: Move BadgeInfoResp + ChallengeArenaResetInfoResp into handlers.kdl; use datetime-unix::str for timestamps#24

Merged
arves100 merged 3 commits into
decompfrontier:mainfrom
Tom2096:fix/badgeinfo-dispatch-wrapper
May 12, 2026
Merged

fix: Move BadgeInfoResp + ChallengeArenaResetInfoResp into handlers.kdl; use datetime-unix::str for timestamps#24
arves100 merged 3 commits into
decompfrontier:mainfrom
Tom2096:fix/badgeinfo-dispatch-wrapper

Conversation

@Tom2096
Copy link
Copy Markdown

@Tom2096 Tom2096 commented May 11, 2026 •
edited
Loading

Changes

  • Moved BadgeInfoResp from net/badge_info.kdl into net/handlers.kdl (kept BadgeInfo data struct in badge_info.kdl)
  • Moved ChallengeArenaResetInfoResp from net/challenge_arena.kdl into net/handlers.kdl (kept ChallengeArenaResetInfo + ChallengeArenaUserInfo data structs)
  • Changed ChallengeArenaResetInfo timestamp fields from str to datetime-unix::str (generates pkg::chrono_time with unix epoch serialization)

Related

@Tom2096 Tom2096 mentioned this pull request May 11, 2026
Open
arves100
arves100 requested changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arves100 arves100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please address my comments thanks!

Comment thread assets/net/badge_info.kdl Outdated
Comment thread assets/net/challenge_arena.kdl Outdated
Comment thread assets/net/challenge_arena.kdl Outdated
Comment thread assets/net/challenge_arena.kdl Outdated
Comment thread assets/net/challenge_arena.kdl Outdated
Comment thread assets/net/challenge_arena.kdl Outdated
Comment thread assets/net/challenge_arena.kdl
Comment thread assets/net/challenge_arena.kdl Outdated
@siyuan2096
Move BadgeInfoResp and ChallengeArenaResetInfoResp into handlers.kdl;…
61fedcc 
… use datetime-unix::str for timestamp fields
@Tom2096 Tom2096 changed the title fix: Add BadgeInfoResp wrapper struct; add .vs/ to gitignore fix: Move BadgeInfoResp + ChallengeArenaResetInfoResp into handlers.kdl; use datetime-unix::str for timestamps May 12, 2026
@Tom2096
Copy link
Copy Markdown
Author

Tom2096 commented May 12, 2026 •
edited
Loading

Sample log json for reference, this is for ChallengeArenaResetInfoResp (Zw3WIoWu):

RESPONSE: {"t6bRQfln":{"xQZe5il8":0,"1fhT0oIQ":1778576934,"QRqWHfJG":0,"z1I0P1Qk":1778573334}}

And for BadgeInfoResp (nJ3A7qFp):

RESPONSE: {"h23iRjGN":{"u7Htm9P4":"0","yCLEs28F":"0","iakSd6m8":"0","4AjsNu0m":"0","dD40xrsh":"0","dUujjBBK":""}}

arves100
arves100 approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@arves100 arves100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's see what the CI has to say first

@arves100 arves100 merged commit 64b0af3 into decompfrontier:main May 12, 2026
13 checks passed
@Tom2096 Tom2096 deleted the fix/badgeinfo-dispatch-wrapper branch May 17, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arves100 arves100 arves100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tom2096 @arves100 @siyuan2096