Skip to content

⚡ Bolt: [performance improvement] Replace slow iterrows with itertuples/to_dict#552

Open
alinelena wants to merge 1 commit into
mainfrom
bolt-optimize-iterrows-415463307187447424
Open

⚡ Bolt: [performance improvement] Replace slow iterrows with itertuples/to_dict#552
alinelena wants to merge 1 commit into
mainfrom
bolt-optimize-iterrows-415463307187447424

Conversation

@alinelena
Copy link
Copy Markdown
Collaborator

💡 What
Replaced slow pandas iterrows() loops with itertuples() or to_dict("records") in:

  • ml_peg/calcs/bulk_crystal/elasticity/calc_elasticity.py
  • ml_peg/calcs/utils/gscdb138.py
  • ml_peg/calcs/conformers/solvMPCONF196/calc_solvMPCONF196.py
  • ml_peg/calcs/conformers/MPCONF196/calc_MPCONF196.py

🎯 Why
iterrows() is notoriously slow in pandas because it instantiates a new pd.Series object for every row it yields, causing severe memory allocation overhead. Using lightweight standard structures like dicts and tuples drastically reduces overhead when running benchmarks over extensive subsets.

📊 Impact
Typical iteration speedup is between 10x and 100x depending on the number of rows. This optimization allows large dataframe iterations in benchmarks to occur almost instantaneously rather than scaling slowly.

🔬 Measurement
I ran ruff check on the altered files and also manually verified that the scripts compile and index references are exact substitutions (using [0]/[2]/attribute matching) in mock test validations.


PR created automatically by Jules for task 415463307187447424 started by @alinelena

Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant