Skip to content

Element filtering#368

Closed
joehart2001 wants to merge 7 commits into
mainfrom
element-filtering-2
Closed

Element filtering#368
joehart2001 wants to merge 7 commits into
mainfrom
element-filtering-2

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Element filtering

  • Element sets are defined in element_sets.yml for example all, hcno).

  • filtering occurs at analysis time:

    • each structures element symbols are collected
    • a boolean mask is built per element set and applied
    • compute metrics + plots on filtered data
  • also recompute a set of category and summary table scores for each element set

To add:

  • periodic table showing which elements are shown

Linked issue

Resolves #255

Testing

LNCI16 for now

@ElliottKasoar ElliottKasoar added the enhancement New feature or request label Feb 16, 2026
@ElliottKasoar
Copy link
Copy Markdown
Collaborator

From testing, one bug to fix is that weights/thresholds for benchmarks are reset when switching tabs

@ElliottKasoar ElliottKasoar mentioned this pull request Apr 29, 2026
1 task
@alinelena
Copy link
Copy Markdown
Collaborator

is superseeded by #512 ?

@ElliottKasoar
Copy link
Copy Markdown
Collaborator

ElliottKasoar commented May 13, 2026

Yep, superseded by #512, which may itself be superseded by a simpler form initially. We'll keep the branch since it has some useful bits to borrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by elements

3 participants