Conversation
- Add ruff to dev dependencies - Configure ruff with line-length=120 and select lint rules for E,W,F,I,UP,B,C4,T10 - Format codebase with ruff (sort imports, convert to f-strings)
- Run ruff linting and format checks on push and pull requests - Check both source code and tests for compliance
- Run ty check as part of lint job - Checks both source and test code for type errors
- Export PyTextractor from __init__.py for cleaner imports - Add py.typed marker to indicate package supports type checking
- Change from relative import (from .pytextractor) to absolute import (from pytextractor) - Improves compatibility with type checkers like ty
- Format test_detector.py with ruff for consistency
- Add @pytest.mark.pytesseract marker to tests requiring pytesseract - Configure pytest marker in pyproject.toml - Update CI test workflow to skip pytesseract tests with -m 'not pytesseract' - Local test runs still include all tests, CI skips pytesseract-dependent ones
- Test that text_detector CLI accepts --help flag - Verify help text contains description - Simple smoke test for command-line interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.