coverage: exclude contract declarations from line coverage#770
Open
coverage: exclude contract declarations from line coverage#770
Conversation
dguido
requested review from
Xenomega,
anishnaik and
samalws-tob
as code owners
Contract declaration lines (contract, library, interface, abstract contract) are not executable code but were being counted in coverage calculations. This caused misleading coverage percentages where contracts with 100% actual code coverage would show less because the declaration line was counted as uncovered. This change: - Adds ContractDeclarationLines map to SourceFileAnalysis to track which line indices contain contract declarations - Parses ContractDefinition nodes from AST to identify declaration lines - Skips marking contract declaration lines as active/executable in analyzeContractSourceCoverage Fixes #286 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dguido
force-pushed
the
dev/exclude-contract-from-coverage
branch
from
c4bc794 to
1a892e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
ContractDeclarationLinesmap toSourceFileAnalysisto track declaration line indicesContractDefinitionnodes from AST during source analysis to identify declaration linesanalyzeContractSourceCoverageFixes #286
Test plan
go build ./...🤖 Generated with Claude Code