fix: thread custom solc path and env through SolcStandardJson#681
Open
cats2101 wants to merge 1 commit intocrytic:masterfrom
Open
fix: thread custom solc path and env through SolcStandardJson#681cats2101 wants to merge 1 commit intocrytic:masterfrom
cats2101 wants to merge 1 commit intocrytic:masterfrom
Conversation
SolcStandardJson.compile() captured `solc` and `solc_env` kwargs but never forwarded them to run_solc_standard_json, so a custom solc binary path passed via CryticCompile(solc=...) was silently ignored — the subprocess was always invoked as plain "solc". Add `solc` and `solc_env` kwargs to run_solc_standard_json (defaulting to the previous behavior) and pass them through from compile(). Closes crytic#672.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #672.
Summary
SolcStandardJson.compile()capturedsolcandsolc_envkwargs but never forwarded them torun_solc_standard_json. As a result, a customsolcbinary path passed viaCryticCompile(target=SolcStandardJson(...), solc=...)was silently ignored — the subprocess was always invoked as plain"solc", which undersolc-selectraisesVersion 'X.Y.Z' not installed (set by SOLC_VERSION)when the configured version isn't installed for the wrapper.This PR threads the captured
solc(binary) andsolc_env(extra environment) values fromcompile()through torun_solc_standard_json(), mirroring howSolc.compile()already uses them.Changes
run_solc_standard_json()accepts newsolcandsolc_envkwargs (default to current behavior, so existing callers — includingcompile_with_filenamesin the same file — keep working).SolcStandardJson.compile()passes through both values.tests/test_solc_standard_json.py) mocksubprocess.Popento assert the executable and environment merge.Test plan
pytest tests/test_solc_standard_json.py -v— 3 new tests passpytest tests/test_zip_archive.py -v— existing tests still passruff check crytic_compile/ tests/ruff format --checkty check crytic_compile/