fix(security): replace eval() with safe parsing in template code#5104
Open
xr843 wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix(security): replace eval() with safe parsing in template code#5104xr843 wants to merge 1 commit intocrewAIInc:mainfrom
xr843 wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
Replaces unsafe eval() call in the Calculator tool example that processes unsanitized LLM output with an AST-based safe math evaluator to prevent arbitrary code execution. The safe evaluator only allows arithmetic operators (+, -, *, /, **) and numeric literals (int, float), rejecting any function calls, imports, or other Python constructs. Fixes crewAIInc#5056
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval()call in the Calculator tool template (AGENTS.md) with an AST-based safe math evaluator+,-,*,/,**, unary-) and numeric literals (int,float) are allowedValueErrorSecurity Impact
The
crewai createcommand ships this template into new projects. Theeval()call enables arbitrary code execution via indirect prompt injection (e.g., a malicious document tricks the LLM into callingcalculator("__import__('os').system('rm -rf /')")).Before (vulnerable):
After (safe):
Testing
Verified the safe evaluator handles:
2 + 3,10 * 5,100 / 4,2 ** 10,-5 + 3,(2 + 3) * 4__import__('os').system(...),open('/etc/passwd').read(), list comprehensionsTest plan
crewai createstill generates valid projects with the updated templateFixes #5056
🤖 Generated with Claude Code