[6.x] Handle non-inertia responses as page visits#18795
Merged
Conversation
|
Review changes with Changed Files
|
brianjhanson
approved these changes
May 5, 2026
Contributor
brianjhanson
left a comment
brianjhanson
left a comment
There was a problem hiding this comment.
I just updated Link -> CpLink which is our own wrapper around Link that allows us to control the styling more like our other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This prevents Inertia from opening successful requests in a modal if it's visited through
<Link>but doesn't return an Inertia request.We can now always use
<Link>and not worry about if it's a new controller/view we're accessing or a standard responseI've adjusted the settings index page as a test & example.
@brianjhanson I did not commit the built assets as to not pollute the diff