[6.x] Fix backup downloads#18792
Merged
brandonkelly merged 5 commits into6.xfrom May 6, 2026
Merged
Conversation
Changed Files
|
There was a problem hiding this comment.
Pull request overview
Fixes database backup downloads in the Craft CP Inertia UI by ensuring download requests are handled as real file downloads (rather than XHR/Inertia responses), and by aligning the controller response behavior with the CP’s flash-message conventions.
Changes:
- Share CSRF token name/value via the Inertia middleware so native form posts can include a valid CSRF input.
- Update the DB backup utility UI to submit natively when downloading (and use Inertia form posting only for non-download flows).
- Refactor
DbBackupControllerto useRespondsWithFlashfor success/failure responses and to parse the download flag via$request->boolean().
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/Http/Middleware/HandleInertiaRequests.php |
Adds CSRF token name/value to shared Inertia craft props for use by native form submissions. |
src/Http/Controllers/Utilities/DbBackupController.php |
Switches error/success handling to RespondsWithFlash and uses boolean request parsing for downloadBackup. |
resources/js/composables/useCraftData.ts |
Extends the CraftData TypeScript interface to include CSRF token name/value. |
resources/js/components/utilities/DatabaseBackup.vue |
Uses a Vue wrapper checkbox + native form submission for downloads, and injects a CSRF hidden input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…oken' of github.com:craftcms/cms into brian/cms-1903-download-button-on-backups-utility-is-broken
riasvdv
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes backup downloads