Prevent partition compaction to compact any blocks marked for deletion#7391
Open
alexqyle wants to merge 2 commits intocortexproject:masterfrom
Open
Prevent partition compaction to compact any blocks marked for deletion#7391alexqyle wants to merge 2 commits intocortexproject:masterfrom
alexqyle wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Alex Le <leqiyue@amazon.com>
alexqyle
force-pushed
the
compact-deleted-blocks
branch
from
3033283 to
2dc9cb6
Compare
Signed-off-by: Alex Le <leqiyue@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When using bucket index to discover blocks, there would be a chance that block marked for deletion got grouped for compaction. This would cause unnecessary double compaction for the same set of blocks for the same time range. To avoid this, add deletion check in planner to make sure all blocks planned for compaction were not marked for deletion.
Note: the reason not simply re-enable deletion filter in fetcher is that fetcher runs in very early stage of compaction. Blocks are still very likely marked for deletion between fetcher runs and planner got called.
Which issue(s) this PR fixes:
NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]