[CCAP-629][CCAP-575] Support for converting documents and images to pdfs #645
[CCAP-629][CCAP-575] Support for converting documents and images to pdfs #645
Conversation
cram-cfa
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cram-cfa
force-pushed
the
marc-CCAP-629
branch
from
5eb9633 to
3cc5df8
Compare
cram-cfa
force-pushed
the
marc-CCAP-629
branch
from
3cc5df8 to
a1bdb81
Compare
cram-cfa
changed the title
| .conversionSourceFileId(userFileId) | ||
| .build(); | ||
|
|
||
| uploadedConvertedFile = userFileRepositoryService.save(uploadedConvertedFile); |
There was a problem hiding this comment.
The only part that is still unclear to me is where the conversionSourceFileId is set.
There was a problem hiding this comment.
This is generated on line 191; It is the UUID of the entry for the file that was uploaded by the user. It has to be generated in the code -- and not by the database -- so we can properly set the path on the uploaded file. (This was actually a bug before, but since we don't really care what the path is, as long as it's set... it's not actually causing any issues in production, etc)
Once the uploaded file has a UUID, we want the new converted file to have a reference back to that uploaded file -- hence it being the "conversion source file's id".
The code to create the UUID previously was way up at the top of the method, I just moved it to line 191 where it is first ever needed.
Let me know if that explains it!
cram-cfa
changed the title
src/main/java/formflow/library/file/FileConversionService.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/formflow/library/data/UserFileRepositoryService.java
Outdated
Show resolved
Hide resolved
5 participants
Issue tracking number 🔗
https://codeforamerica.atlassian.net/browse/CCAP-629
Description of change ✍️
Priority 🥇
Effect on other applications using FFB 🌊
Testing
✅ Checklist before requesting a review
style?