config(celery): Increase default notify task soft time limit#868
config(celery): Increase default notify task soft time limit#868sentry[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5162a30. Configure here.
| notify_soft_time_limit = int( | ||
| get_config( | ||
| "setup", "tasks", TaskConfigGroup.notify.value, "timeout", default=120 | ||
| "setup", "tasks", TaskConfigGroup.notify.value, "timeout", default=600 |
There was a problem hiding this comment.
Insufficient hard timeout buffer after soft limit increase
Medium Severity
Increasing notify_soft_time_limit from 120 to 600 while the hard limit remains notify_soft_time_limit + 20 (line 474) leaves only a 20-second cleanup window — far smaller than the 80–120 second buffers used for every other task at a similar soft limit. Tasks hitting the soft limit with long-running API calls or DB operations are very likely to be forcibly killed before graceful cleanup completes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5162a30. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1307 1307
Lines 48017 48017
Branches 1636 1636
=======================================
Hits 44299 44299
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |


Fixes WORKER-Y92. The issue was that: Notify task's 120s soft timeout is insufficient for accumulated external API calls and database operations.
This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13567188
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Low risk configuration-only change, but it allows
notifytasks to run longer by default which could increase worker occupancy if tasks stall.Overview
Increases the default Celery soft time limit for
notifytasks from 120s to 600s (and correspondingly extends the annotated hardtime_limit), reducing premature timeouts for slower notification workloads.Reviewed by Cursor Bugbot for commit 5162a30. Bugbot is set up for automated code reviews on this repo. Configure here.