Skip to content

perf(worker): Eagerly load repository for flake processing#864

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/eager-load-repo-flakes
Open

perf(worker): Eagerly load repository for flake processing#864
sentry[bot] wants to merge 1 commit into
mainfrom
seer/perf/eager-load-repo-flakes

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 20, 2026

Fixes WORKER-Y8Y. The issue was that: Missing .select_related() on ReportSession and individual flake.save() calls cause N+1 queries, leading to task timeouts.

  • Added .select_related("report__commit__repository") to the report query in _fetch_reports_for_commit.
  • This change optimizes database access by eagerly loading the related repository object, preventing potential N+1 queries when processing flakes.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13552300

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance-only change that adjusts a Django queryset to prefetch related repository, reducing N+1 queries during flake processing.

Overview
Improves flake-processing performance by updating get_relevant_uploads() to eagerly load report__commit__repository via select_related(), avoiding repeated per-upload repository lookups and helping prevent worker timeouts.

Reviewed by Cursor Bugbot for commit f1ebd80. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (f1ebd80).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1307     1307           
  Lines       48017    48017           
  Branches     1636     1636           
=======================================
  Hits        44299    44299           
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.54% <ø> (ø)
workerunit 90.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants