fix: searchbox cta warnings in form#1368
Merged
Ninfa-Jeon merged 2 commits intoMay 4, 2026
Merged
Conversation
ed260d7 to
7af3eeb
Compare
huwshimi
reviewed
May 3, 2026
Contributor
huwshimi
left a comment
There was a problem hiding this comment.
A few small changes here.
7af3eeb to
0ead970
Compare
huwshimi
approved these changes
May 4, 2026
Contributor
huwshimi
left a comment
There was a problem hiding this comment.
Thanks for the updates!
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
The
SearchBoxcomponent and consequently theMultiSelectcomponent were throwing warnings when rendered within a formik form. This was due to the fact that the search button withinSearchBoxwas being rendered without an explicittype="submit"prop.type="submit"by default onSearchBoxsearch buttonsearchButtonTypeprop in case the button type needs to changedropdownClassName,inputClassNameandfooterClassNameprops to fine tuneMultiSelectas needed. This is because the dropdown is being rendered within a portal, making global override the only other solution.QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
FormikFieldto render multiselect and try clicking the search button on it. The following error should not appear in console: