fix: runprocessfunction in RunProcessFunction.java#411
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
RunProcessFunction Resolves V-001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
src/main/java/net/bramp/ffmpeg/RunProcessFunction.java.Vulnerability
V-001src/main/java/net/bramp/ffmpeg/RunProcessFunction.java:32Description: RunProcessFunction.java passes an args list directly to ProcessBuilder without validating individual argument values for FFmpeg-specific protocol specifiers or unsafe input patterns. Because ProcessBuilder uses array-form invocation (no shell), classic OS shell injection (e.g., '; rm -rf /') is not exploitable. However, if user-supplied filenames are included in the args list without validation, an attacker can inject FFmpeg protocol specifiers such as 'http://attacker.com/malicious.m3u8', 'data://text/plain;base64,...', 'pipe:', or 'rtmp:' to cause FFmpeg to fetch remote content, access unintended resources, or trigger unexpected FFmpeg behaviors. The vulnerability exists at the FFmpegBuilder argument construction layer where user input is incorporated into the args array.
Changes
src/main/java/net/bramp/ffmpeg/RunProcessFunction.javaVerification
Automated security fix by OrbisAI Security