Euclidean generator and tsp enhancements#463
Open
megyhazy wants to merge 5 commits intoboostorg:developfrom
Open
Euclidean generator and tsp enhancements#463megyhazy wants to merge 5 commits intoboostorg:developfrom
megyhazy wants to merge 5 commits intoboostorg:developfrom
Conversation
…raph generation functions
megyhazy
changed the title
Becheler
requested changes
Mar 30, 2026
Collaborator
There was a problem hiding this comment.
I guess you deleted the .gitignore file by mistake and committed your changes. This should probably be restored :)
Collaborator
There was a problem hiding this comment.
For the CI to compile and run your tests, the tests should be listed in the test/Jamfile.v2 under the alias graph_test_regular : category :)
[ run generator_test.cpp ]
[ run euclidean_graph_generator_test.cpp ]
| const WeightType weight = static_cast<WeightType>(std::hypot(dx, dy)); | ||
|
|
||
| // No need to check 'inserted' - building fresh complete graph | ||
| Edge e = boost::add_edge(*src, *dest, g).first; |
Collaborator
There was a problem hiding this comment.
Looks like there should be a BOOST_CONCEPT_ASSERT((MutableGraphConcept < VertexListGraph >)); somewhere ?
|
|
||
| // Deduce coordinate type from the point container | ||
| using PointType = typename PointContainer::value_type; | ||
| using CoordType = decltype(std::declval<PointType>().x); |
| // Precondition: Graph should have no edges | ||
| BOOST_ASSERT_MSG(boost::num_edges(g) == 0, | ||
| "connect_all_euclidean requires an empty graph (no edges)"); | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe there is a missing precondition that the Point Container should have same size as the graph ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoughts: