Security: Sensitive secret material is echoed in error output#3029
Open
tuanaiseo wants to merge 20 commits intoblacklanternsecurity:3.0from
Open
Conversation
…y/dev Dev -> Stable 2.8.4
…y/update-docs Automated Docs Update
Replace the single PR-author org membership check with a unified step that iterates all committers on the PR and checks each against: 1. GitHub API account type (type == "Bot" for App accounts) 2. Org membership Commits with no associated GitHub login are treated as non-exempt (prevents bypass via spoofed email with no GitHub account). Tested on aconite33/cla-workflow-test: - Human committer: correctly required CLA - github-actions[bot]: correctly skipped via API type check
Tested on aconite33/cla-workflow-test with only pull-requests:write and statuses:write -- both human CLA and bot skip paths work correctly. The CLA assistant uses PERSONAL_ACCESS_TOKEN (app token) for writing signatures to the remote CLA repo, not GITHUB_TOKEN.
…y/fix-cla-bot-skip Fix CLA workflow to skip bots and check all committers
# Conflicts: # .github/workflows/cla.yml
…y/merge-stable-into-dev Merge stable into dev to resolve CLA workflow conflict
…y/dev Merge dev into stable: CLA workflow update
On decryption failure, the script logs the full encrypted sudo password blob in stderr (`Error decrypting password "..."`). Even encrypted secrets should be treated as sensitive since they can be harvested from logs and reused for offline analysis or correlation attacks. Affected files: sudo_askpass.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On decryption failure, the script logs the full encrypted sudo password blob in stderr (
Error decrypting password "..."). Even encrypted secrets should be treated as sensitive since they can be harvested from logs and reused for offline analysis or correlation attacks.Severity:
highFile:
bbot/core/helpers/depsinstaller/sudo_askpass.pySolution
Never include secret values in error messages. Replace with a generic message (e.g.,
Error decrypting sudo password) and optionally include a non-sensitive error code.Changes
bbot/core/helpers/depsinstaller/sudo_askpass.py(modified)Testing