zCinematic small matches#738
Open
LSLees wants to merge 2 commits into
Open
Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .rodata |
11.73% | 12.30% | +21 |
| 📈 | .text |
21.94% | 23.62% | +295 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | NCINBeNosey::Init(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 96.25% | +15 |
| ✅ | NCINBeNosey::Done() |
0.00% | 100.00% | +20 |
| ✅ | NCIN_MidFish_Upd(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 100.00% | +24 |
| ✅ | NCIN_BombTrail_Upd(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 100.00% | +24 |
| ✅ | NCIN_BombTrail_AR(const zCutsceneMgr*, NCINEntry*, RpAtomic*, RwMatrixTag*, unsigned int, unsigned int) |
0.00% | 100.00% | +48 |
| ✅ | NCIN_BoneTrail_Upd(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 100.00% | +24 |
| ✅ | NCIN_BoneTrail_AR(const zCutsceneMgr*, NCINEntry*, RpAtomic*, RwMatrixTag*, unsigned int, unsigned int) |
0.00% | 100.00% | +48 |
| ✅ | NCIN_HookRecoil_Upd(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 100.00% | +24 |
| ✅ | NCIN_SpatGlow_Upd(const zCutsceneMgr*, NCINEntry*, int) |
0.00% | 100.00% | +24 |
| ✅ | xCutscene::NoseyClear() |
0.00% | 100.00% | +36 |
| ✅ | xCutscene::NoseySet(XCSNNosey*) |
0.00% | 100.00% | +8 |
SquareMan
requested changes
May 12, 2026
| { | ||
| this->use_fxtab = e; | ||
| this->x = i; | ||
| this->use_csnmgr = (zCutsceneMgr*)m; |
Member
There was a problem hiding this comment.
Have you checked if the use_csnmgr field on this class can be const zCutsceneMgr* here instead of zCutsceneMgr* to avoid the need to cast away constness here?
| { | ||
| zCutsceneMgr* use_csnmgr; | ||
| NCINEntry* use_fxtab; | ||
| S32 x; |
Member
There was a problem hiding this comment.
I don't see this field in the dwarf for this class. Let's review the asm that's accessing this field and see if we can figure out what's really going on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.