fix(mbsync): do not clear metadata if import.from_scratch is set#6625
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6625 +/- ##
=======================================
Coverage 72.38% 72.39%
=======================================
Files 159 159
Lines 20645 20649 +4
Branches 3269 3270 +1
=======================================
+ Hits 14944 14948 +4
Misses 4976 4976
Partials 725 725
🚀 New features to boost your workflow:
|
snejus
reviewed
May 13, 2026
Member
snejus
left a comment
There was a problem hiding this comment.
Thanks for addressing this. I agree that we should ignore import.from_scratch configuration when we synchronise data.
I've seen multiple new issues and discussions created due to this problem, so this has definitely been causing confusion to people.
Maybe worth updating bpsync plugin as well, for consistency?
60623c5 to
b3f9b9e
Compare
Contributor
Author
|
@snejus done |
if import.from_scratch was set in the config, runnning mbsync would clear any metadata not provided by MBz (replay gain, lyrics, genres...). we now ignore this setting when running mbsync to preserve metadata. Fixes: beetbox#6613
b3f9b9e to
65ccaf1
Compare
snejus
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
if import.from_scratch was set in the config, runnning mbsync would clear any metadata not provided by MBz (replay gain, lyrics, genres...). we now ignore this setting when running mbsync to preserve metadata.
Fixes: #6613
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)