Skip to content

toolchain: Switch to link_libs for libstdc++#625

Merged
helly25 merged 2 commits into
bazel-contrib:masterfrom
phlax:link_libs
May 9, 2026
Merged

toolchain: Switch to link_libs for libstdc++#625
helly25 merged 2 commits into
bazel-contrib:masterfrom
phlax:link_libs

Conversation

@phlax
Copy link
Copy Markdown
Contributor

@phlax phlax commented Nov 27, 2025

No description provided.

Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Copy Markdown
Collaborator

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's see if we break anyone :)

Not gonna block on this but it would be awesome to add a test with the sanitizer setup you were mentioning

@phlax
Copy link
Copy Markdown
Contributor Author

phlax commented Dec 2, 2025

id like to offer to add tests - but realistically im unlikely to have spare cycles for this just now - also our san setup is kinda specific to our ci build pipeline so isolating a minimal reproducer is not straightforward

fwiw, the issue related to instrumented libc++ libs so not directly related to this pr - altho, i should say, we dont test clang+libstdc++ so this change is untested from our end

@helly25
Copy link
Copy Markdown
Collaborator

helly25 commented May 9, 2026

If this gets merged I will see if more tests are necessary.

@phlax
Copy link
Copy Markdown
Contributor Author

phlax commented May 9, 2026

if you could hold off just a little - ill update to our latest patch - it renames the arg so keen to have update included

@phlax
Copy link
Copy Markdown
Contributor Author

phlax commented May 9, 2026

oh wait .. i mixed this up with the other pr for x-compiling - will update that one today

@helly25 helly25 merged commit 9b1497d into bazel-contrib:master May 9, 2026
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants