feat: add configurable npm registry URL for publishers#2314
Open
jpoehnelt wants to merge 1 commit intoaxodotdev:mainfrom
Open
feat: add configurable npm registry URL for publishers#2314jpoehnelt wants to merge 1 commit intoaxodotdev:mainfrom
jpoehnelt wants to merge 1 commit intoaxodotdev:mainfrom
Conversation
Add a `registry` option to the npm publisher config so users can
publish to custom npm registries instead of the hardcoded
https://registry.npmjs.org.
Config example:
[dist.publishers.npm]
registry = "https://example.com"
When omitted, defaults to https://registry.npmjs.org (current behavior).
Changes:
- Added `registry: Option<String>` to NpmPublisherLayer/NpmPublisherConfig
- Added `npm_registry_url: String` to GithubCiInfo (auto-populates template)
- Updated publish_npm.yml.j2 to use template variable
- Updated snapshot tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
registryoption to the npm publisher config so users can publish to custom npm registries instead of the hardcoded https://registry.npmjs.org.Config example:
When omitted, defaults to https://registry.npmjs.org (current behavior).
Changes:
- Added
registry: Option<String>to NpmPublisherLayer/NpmPublisherConfig- Added
npm_registry_url: Stringto GithubCiInfo (auto-populates template)- Updated publish_npm.yml.j2 to use template variable
- Updated snapshot tests
Fixes: #2316