feat(apigatewayv2): expose disableExecuteApiEndpoint for WebSocketApi#37882
Draft
MukundaKatta wants to merge 1 commit into
Draft
feat(apigatewayv2): expose disableExecuteApiEndpoint for WebSocketApi#37882MukundaKatta wants to merge 1 commit into
MukundaKatta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #35516.
Reason for this change
HttpApialready exposesdisableExecuteApiEndpoint, andCfnApisupportsDisableExecuteApiEndpointfor API Gateway v2 APIs.WebSocketApicurrently does not expose or pass through the property, which prevents users from disabling the default execute-api endpoint without dropping down to lower-level constructs.Description of changes
disableExecuteApiEndpointtoWebSocketApiProps.AWS::ApiGatewayV2::Api.HttpApibehavior by throwing whenapiEndpointis accessed while the default endpoint is disabled.apiEndpointaccess.Description of how you validated changes
jest test/websocket/api.test.ts --runInBandusing the existing local AWS CDK toolchain. The test runner could not start in the fresh worktree because generatedcore/distartifacts were missing (../dist/core/cfn-utils-provider.generated).HttpApipattern and checked the synthesized property expectations in the focused test changes.Checklist