fix(ui): Hide Edit/Upgrade flows; document CloudShell day-2 commands#97
Merged
Conversation
The Edit (update.sh) and Upgrade (upgrade.sh) flows are disabled from the configurator landing page. Both had critical bugs: - Upgrade: blows scoped_account_ids to ["ALL"] because new CFN parameters default to placeholder values when upgrading from older template versions that lacked those parameters. - Edit: uses sed on template body which is incompatible with the new !Sub-based SSM config format. Changes: - Comment out Edit and Upgrade mode cards in configurator HTML - Add Day-2 CloudShell commands to INSTRUCTIONS.md for add/remove accounts via update-stack-set parameter update - Update README with CloudShell day-2 workflow and delete-redeploy upgrade path - Document in-place upgrade limitation and reconciliation removal in LIMITATIONS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Edit (update.sh) and Upgrade (upgrade.sh) flows are disabled from the configurator landing page. Both had critical bugs:
Changes:
Description
Brief description of the change and the problem it solves.
Type of change
Testing
Checklist
cfn-lintpasses — checked by CI).github/scripts/resource_groups/for E2E coverageCHANGELOG.mdupdatedCI Notes