Limiting the branching factor and the depth of branching

[msooseth]

Description

This is a rewrite of the branch width limitation, along with a new branch depth limitation. It should make things a lot cleaner and tidier. Less noise, more sense. Added some tests, too.

Checklist

• tested locally
• added automated tests
• updated the docs
• updated the changelog

[msooseth]

@blishko First of all, thanks for the review! I think it helped making this better :) Can you maybe take another peek at this? I tried clarifying the issues you found, hopefully it's in a better state now.

[blishko]

Looks OK to me, though I would like to see some documentation on why you sometime pass the limit to branch, and sometime you explicitly disable it by passing Nothing.
How should one decide when do one or the other?

[msooseth]

Looks OK to me, though I would like to see some documentation on why you sometime pass the limit to branch, and sometime you explicitly disable it by passing Nothing. How should one decide when do one or the other?

Actually, very good point. Thank you for that! It turns out that I did that only because I didn't have conf.maxExplore in context, so I cheated... It's just wrong. I'll fix it. Thank you, this has been super-helpful, as always!

[msooseth]

You were spot on. This f4ab216 fixes the issue now. Thank you, you always find some really nice things! Let me know if this fixes the issue :)

Mate

[blishko]

I still lack sufficient knowledge to have a good picture how the exploration proceeds.
But I don't see any obvious issues, so we can try to proceed :)

[msooseth]

I still lack sufficient knowledge to have a good picture how the exploration proceeds. But I don't see any obvious issues, so we can try to proceed :)

I re-wrote it so hopefully it will be easier to review. It really ought to be easy to review, if not, I likely messed something up... so I decided to rewrite the multi-solution system to be much more clear and straightforward. This should make it so much easier to follow the control flow. The patterns of use of branching should also be much clearer and more consistent now. Honestly, previously, it was a mess, and likely also wrong. We now have a much cleaner --max-width and --max-depth flags, and they do what they say on the lid.

[blishko]

I like the new design! Still have some minor questions, though.