Fix extended string delimiter selection in renderLiteral#898
Merged
kukushechkin merged 1 commit intoApr 24, 2026
Merged
Conversation
FranzBusch
approved these changes
Apr 20, 2026
When the string content contains `"#` or `\#`, a single-hash raw literal (`#"..."#`) produces unexpected Swift code. Dynamically pick the minimum number of `#` delimiters so that neither the closing sequence nor the escape prefix appears in the content.
kukushechkin
force-pushed
the
fix-string-delimiter-handling-in-renderLiteral
branch
from
b230378 to
c4a43f0
Compare
simonjbeaumont
approved these changes
Apr 20, 2026
Collaborator
simonjbeaumont
left a comment
simonjbeaumont
left a comment
There was a problem hiding this comment.
Thanks @kukushechkin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically pick the minimum number of
#delimiters so that neither the closing sequence nor the escape prefix appears in the content.Motivation
When the string content contains
"#or\#, a single-hash raw literal (#"..."#) produces unexpected Swift code.Modifications
#delimiters so that neither the closing sequence nor the escape prefix appears in the content.Result
No unexpected Swift code is generated.
Test Plan
Unit tests.