Use allocate with session to automatically clean up IPs.#1544
Merged
Conversation
- Removes network plugin `deallocate()`, and allocate takes an `XPCServerSession` that registers an `onDisconnect` handler that performs deallocation. - ContainerService now tracks `networkSessions` for allocations.
Code Coverage
|
| private let log: Logger | ||
| private var allocator: AttachmentAllocator | ||
| private var macAddresses: [UInt32: MACAddress] | ||
| private var allocationsBySession: [XPCServerSession: [(hostname: String, index: UInt32)]] = [:] |
Contributor
There was a problem hiding this comment.
small, small nit but could we set this default value in the init for consistency?
Contributor
Author
There was a problem hiding this comment.
Sure! I'll fix in the third PR.
katiewasnothere
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP allocator cannot be disabled with active containers#1318.deallocate(), and allocate takes anXPCServerSessionthat registers anonDisconnecthandler that performs deallocation.networkSessionsfor allocations.Type of Change
Motivation and Context
Fix bug and simplify IP allocation.
Testing