fix: evaluate ManifestGroup file filters#664
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #663.
This implements
ManifestGroup::FilterFiles()instead of accepting the filter as a silent no-op. The change adds aDataFileStructLikewrapper, binds and caches file-level evaluators per partition spec, and applies the evaluator to each manifest entry before returning it.The reader projection now also includes file-filter referenced metadata columns when callers use
Select(...), including widening nested partition references to the fullpartitionstruct so partition filters evaluate against the correct positional values.Tests
uvx pre-commit run --files src/iceberg/manifest/manifest_group.cc src/iceberg/row/manifest_wrapper.cc src/iceberg/row/manifest_wrapper.h src/iceberg/test/manifest_group_test.ccuvx cmake --build build --target manifest_test -j 8./build/src/iceberg/test/manifest_test --gtest_filter='ManifestGroupVersions/ManifestGroupTest.FilterFiles*'./build/src/iceberg/test/manifest_test