[fix] avoid concurrent tablet stat iteration failures#63298
Open
yx-keith wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 30762 ms |
Contributor
TPC-DS: Total hot run time: 167902 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #59138
Related PR: #xxx
Problem Summary:
TabletStatMgr may hit concurrency issues when FE metadata changes during tablet stat collection. MaterializedIndex.getTablets() and LocalTablet.getReplicas() return internal mutable lists directly, and updateTabletStat() also has a stale-metadata window between getTabletMeta() and getReplica().
Solution:
This PR makes the tablet stat read path more robust:
return snapshot lists from MaterializedIndex.getTablets() and LocalTablet.getReplicas()
skip stale stat updates in TabletStatMgr.updateTabletStat() when tablet metadata is removed concurrently
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)