[Improvement-18249][DAO] Route ProjectUserMapper access through ProjectUserDao#18262
Open
ruanwenjun wants to merge 1 commit into
Open
[Improvement-18249][DAO] Route ProjectUserMapper access through ProjectUserDao#18262ruanwenjun wants to merge 1 commit into
ruanwenjun wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| Arrays.stream(projectIds.split(Constants.COMMA)).distinct().forEach(projectId -> { | ||
| ProjectUser projectUserOld = projectUserMapper.queryProjectRelation(Integer.parseInt(projectId), userId); | ||
| ProjectUser projectUserOld = projectUserDao.queryProjectRelation(Integer.parseInt(projectId), userId); |
| ProjectUser projectUserOld = projectUserDao.queryProjectRelation(Integer.parseInt(projectId), userId); | ||
| if (projectUserOld != null) { | ||
| projectUserMapper.deleteProjectRelation(Integer.parseInt(projectId), userId); | ||
| projectUserDao.deleteProjectRelation(Integer.parseInt(projectId), userId); |
| } | ||
| Arrays.stream(projectIds.split(",")).distinct().forEach(projectId -> { | ||
| ProjectUser projectUserOld = projectUserMapper.queryProjectRelation(Integer.parseInt(projectId), userId); | ||
| ProjectUser projectUserOld = projectUserDao.queryProjectRelation(Integer.parseInt(projectId), userId); |
| ProjectUser projectUserOld = projectUserDao.queryProjectRelation(Integer.parseInt(projectId), userId); | ||
| if (projectUserOld != null) { | ||
| projectUserMapper.deleteProjectRelation(Integer.parseInt(projectId), userId); | ||
| projectUserDao.deleteProjectRelation(Integer.parseInt(projectId), userId); |
ruanwenjun
force-pushed
the
dao/project-user
branch
2 times, most recently
from
05a7688 to
aceca63
Compare
…ctUserDao Introduce ProjectUserDao so the api layer depends only on the repository abstraction. The Dao exposes queryProjectRelation as a straight delegate and packages deleteProjectRelation as void since the row-count return was never consulted at the api call sites. Tracking issue: apache#18249
ruanwenjun
force-pushed
the
dao/project-user
branch
from
aceca63 to
700e9c3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, gpt 5.5
Purpose of the pull request
Introduce ProjectUserDao so the api layer depends only on the repository abstraction. The Dao exposes queryProjectRelation as a straight delegate and packages deleteProjectRelation as void since the row-count return was never consulted at the api call sites.
Tracking issue: #18249
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md