Skip to content

Fix PostCommit Java ValidatesRunner Flink job #38418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
May 8, 2026
+1 −0
Merged

Fix PostCommit Java ValidatesRunner Flink job #38418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public void testMetadataPropagationAcrossShuffleParameter() {
@Test
@Category({ValidatesRunner.class, NeedsRunner.class})
public void testMetadataPropagationParameter() {
WindowedValues.WindowedValueCoder.setMetadataSupported();
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The class name should be WindowedValue (singular) and the setMetadataSupported method requires a boolean argument (e.g., true). Additionally, this method is typically called on WindowedValue directly rather than the coder inner class. Note that modifying global static state in a test can lead to side effects in other tests; consider resetting this state after the test execution.

Suggested change
WindowedValues.WindowedValueCoder.setMetadataSupported();
WindowedValue.setMetadataSupported(true);

PCollection<String> results =
pipeline
.apply(Create.of(true))
Expand Down
Loading