Mitigate test broken after Avro Upgrade due to AVRO-4110#38405
Mitigate test broken after Avro Upgrade due to AVRO-4110#38405Abacn merged 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a temporary mitigation for test failures caused by the recent Avro 1.12.0 upgrade (AVRO-4110). It adds a utility to patch test data lists and provides specific overrides in the schema transform tests to ensure compatibility with the updated Avro library behavior until a permanent resolution is available. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a workaround for AVRO-4110 by providing specialized test data and overriding array primitive data type tests for Avro and Parquet providers. A ListPatcher utility was added to manage these data variations. Review feedback recommends refactoring this utility to use standard Java collections and interfaces instead of vendored Guava utilities, and ensuring fields are marked as final.
| import org.apache.beam.sdk.io.common.SchemaAwareJavaBeans.SinglyNestedDataTypes; | ||
| import org.apache.beam.sdk.io.common.SchemaAwareJavaBeans.TimeContaining; | ||
| import org.apache.beam.sdk.values.Row; | ||
| import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Lists; |
There was a problem hiding this comment.
This import is no longer needed if the ListPatcher class is refactored to use the standard ArrayList constructor instead of the vendored Guava utility.
| private static class ListPatcher<T> { | ||
| private ArrayList<T> list; | ||
|
|
||
| ListPatcher(List<T> list) { | ||
| this.list = Lists.newArrayList(list); | ||
| } | ||
|
|
||
| ArrayList<T> get() { | ||
| return list; | ||
| } | ||
|
|
||
| ListPatcher<T> patch(int index, T value) { | ||
| list.set(index, value); | ||
| return this; | ||
| } | ||
| } |
There was a problem hiding this comment.
The ListPatcher utility class can be improved by following Java best practices: using the List interface for the internal field and return types, and marking the field as final. Additionally, using the standard ArrayList constructor is preferred over the vendored Guava utility Lists.newArrayList() to avoid unnecessary dependencies in test code.
private static class ListPatcher<T> {\n private final List<T> list;\n\n ListPatcher(List<T> list) {\n this.list = new ArrayList<>(list);\n }\n\n List<T> get() {\n return list;\n }\n\n ListPatcher<T> patch(int index, T value) {\n list.set(index, value);\n return this;\n }\n }
|
R: @Amar3tto |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
2 participants
Please add a meaningful description for your change here
Fix #33793
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.