Skip to content

[ErrorProne ] fix violation in ValueInSingleWindow #38372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stankiewicz merged 1 commit into from
May 5, 2026
Merged

[ErrorProne ] fix violation in ValueInSingleWindow #38372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/values/ValueInSingleWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,14 @@ public static <T> Coder<T> of(
@Override
public void encode(ValueInSingleWindow<T> windowedElem, OutputStream outStream)
throws IOException {
encode(windowedElem, outStream, Coder.Context.NESTED);
encode(windowedElem, outStream, org.apache.beam.sdk.coders.Coder.Context.NESTED);
}

@Override
public void encode(
ValueInSingleWindow<T> windowedElem, OutputStream outStream, Coder.Context context)
ValueInSingleWindow<T> windowedElem,
OutputStream outStream,
org.apache.beam.sdk.coders.Coder.Context context)
throws IOException {
InstantCoder.of().encode(windowedElem.getTimestamp(), outStream);
windowCoder.encode(windowedElem.getWindow(), outStream);
Expand Down Expand Up @@ -154,13 +156,13 @@ public void encode(

@Override
public ValueInSingleWindow<T> decode(InputStream inStream) throws IOException {
return decode(inStream, Coder.Context.NESTED);
return decode(inStream, org.apache.beam.sdk.coders.Coder.Context.NESTED);
}

@Override
@SuppressWarnings("IgnoredPureGetter")
public ValueInSingleWindow<T> decode(InputStream inStream, Coder.Context context)
throws IOException {
public ValueInSingleWindow<T> decode(
InputStream inStream, org.apache.beam.sdk.coders.Coder.Context context) throws IOException {
Comment thread
stankiewicz marked this conversation as resolved.
Instant timestamp = InstantCoder.of().decode(inStream);
BoundedWindow window = windowCoder.decode(inStream);
PaneInfo paneInfo = PaneInfo.PaneInfoCoder.INSTANCE.decode(inStream);
Expand Down
Loading