docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md#2750
docs: remove redundant namespace from HTTPRoute, Ingress, and ApisixRoute examples in configure-routes.md#2750fengqi-dev wants to merge 1 commit intoapache:masterfrom
Conversation
…oute examples in configure-routes.md
There was a problem hiding this comment.
Pull request overview
This PR updates the getting-started routing documentation to avoid repeating the ingress-apisix namespace in example manifests, aligning the examples with the earlier prerequisite step that sets the kubectl context namespace.
Changes:
- Removed
metadata.namespace: ingress-apisixfrom the HTTPRoute example. - Removed
metadata.namespace: ingress-apisixfrom the Ingress example. - Removed
metadata.namespace: ingress-apisixfrom the ApisixRoute example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I don't think this change is safe as-is. Removing For the The same issue applies to the Ingress and I think we should either:
Right now this PR makes the docs less explicit and potentially incorrect for the Gateway API case. |
Type of change:
What this PR does / why we need it:
This pull request makes minor updates to the documentation in
docs/en/latest/getting-started/configure-routes.mdby removing thenamespace: ingress-apisixfield from several Kubernetes resource examples.apisix-ingress-controller/examples/httpbin/deployment.yaml
Lines 60 to 63 in 878e501
Pre-submission checklist: