Skip to content

docs: add apisix.apache.org/parameters-namespace to annotation doc#2702

Merged
kayx23 merged 6 commits intomasterfrom
parameters-namespace
Jan 16, 2026
Merged

docs: add apisix.apache.org/parameters-namespace to annotation doc#2702
kayx23 merged 6 commits intomasterfrom
parameters-namespace

Conversation

@kayx23
Copy link
Copy Markdown
Member

@kayx23 kayx23 commented Jan 13, 2026 •
edited
Loading

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Add apisix.apache.org/parameters-namespace to annotation doc.

feat: #2701

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

ronething
ronething reviewed Jan 13, 2026
View reviewed changes
Comment thread docs/en/latest/reference/ingress-annotation.md Outdated
@kayx23 kayx23 requested a review from ronething January 13, 2026 08:27
@ronething
Copy link
Copy Markdown
Contributor

ronething commented Jan 13, 2026

I found that this change has been placed in the Ingress Annotation related documentation, but actually it is supported by IngressClass, which may not be very appropriate.

@kayx23
Copy link
Copy Markdown
Member Author

kayx23 commented Jan 13, 2026

@ronething Fair point. Please don't merge this PR yet and I will make some adjustments.

@kayx23 kayx23 marked this pull request as draft January 13, 2026 10:19
@kayx23 kayx23 marked this pull request as ready for review January 16, 2026 07:06
@kayx23
Copy link
Copy Markdown
Member Author

kayx23 commented Jan 16, 2026

@ronething made the title and writing more generic for all annotations.

@kayx23 kayx23 merged commit 2b7b247 into master Jan 16, 2026
24 of 25 checks passed
@kayx23 kayx23 deleted the parameters-namespace branch January 16, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronething ronething ronething approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kayx23 @ronething @AlinsRan