fix: Add provider endpoints to translate context#2442
Merged
nic-6443 merged 5 commits intoapache:masterfrom Jul 2, 2025
Merged
fix: Add provider endpoints to translate context#2442nic-6443 merged 5 commits intoapache:masterfrom
nic-6443 merged 5 commits intoapache:masterfrom
Conversation
AlinsRan
reviewed
Jul 2, 2025
Contributor
|
You need to add more description for this PR. |
AlinsRan
approved these changes
Jul 2, 2025
ronething
reviewed
Jul 2, 2025
nic-6443
approved these changes
Jul 2, 2025
AlinsRan
pushed a commit
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
In the previous implementation, there were two issues:
This PR solves these two issues.
gatewayproxy provider.controlPlane.endpoints will no longer be required. At least and at most one of endpoints and servcie is required.
When processing various CRDs, if they are associated with GatewayProxy, try to add the Service and EndpointSlices referenced by GatewayProxy to TranslateContext if the portover service is not nil. When configuring adc, the Service and EndpointSlice will be taken out of TranslateContext, the corresponding port will be found, and spliced into the adc server address.
Pre-submission checklist: