Skip to content

fix: Add provider endpoints to translate context#2442

Merged
nic-6443 merged 5 commits intoapache:masterfrom
dspo:fix/adc-service-address
Jul 2, 2025
Merged

fix: Add provider endpoints to translate context#2442
nic-6443 merged 5 commits intoapache:masterfrom
dspo:fix/adc-service-address

Conversation

@dspo
Copy link
Copy Markdown
Contributor

@dspo dspo commented Jul 2, 2025

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

In the previous implementation, there were two issues:

  • gatewayproxy provider.controlPlane.endpoints is required and has a higher priority than provider.controlPlane.service, which means that even if provider.controlPlane.service is configured, it will not take effect
  • provider.controlPlane.service is not added to translateContext, which means that the configuration cannot be sent to each dataplane instance separately.

This PR solves these two issues.

gatewayproxy provider.controlPlane.endpoints will no longer be required. At least and at most one of endpoints and servcie is required.

When processing various CRDs, if they are associated with GatewayProxy, try to add the Service and EndpointSlices referenced by GatewayProxy to TranslateContext if the portover service is not nil. When configuring adc, the Service and EndpointSlice will be taken out of TranslateContext, the corresponding port will be found, and spliced ​​into the adc server address.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Comment thread internal/provider/adc/config.go Outdated
@AlinsRan
Copy link
Copy Markdown
Contributor

AlinsRan commented Jul 2, 2025

You need to add more description for this PR.

@dspo dspo requested a review from AlinsRan July 2, 2025 08:15
@AlinsRan AlinsRan requested a review from ronething July 2, 2025 09:35
Comment thread internal/provider/adc/config.go
@nic-6443 nic-6443 merged commit 59ded94 into apache:master Jul 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants