chore: set default provider type#2436
Merged
AlinsRan merged 1 commit intoapache:masterfrom Jun 27, 2025
Merged
Conversation
Signed-off-by: ashing <axingfly@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default provider type from "apisix-standalone" to "apisix" to ensure consistency across configuration files and tests.
- Replace hard-coded strings with framework constants.
- Update manifests, constants, internal configuration, and sample configurations.
- Remove legacy ADC backend environment variable assignment.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scaffold/apisix_deployer.go | Uses framework.ProviderType to determine the backend provider value. |
| test/e2e/scaffold/adc.go | Removes ADC_BACKEND env var assignment in the dumpResources function. |
| test/e2e/framework/manifests/ingress.yaml | Updates the default provider type in the ingress manifest. |
| test/e2e/framework/apisix_consts.go | Changes the default ProviderType constant to "apisix". |
| internal/controller/config/config.go | Replaces ProviderTypeStandalone with ProviderTypeAPISIX in config. |
| config/samples/config.yaml | Updates sample configuration to use "apisix" as the provider type. |
Comments suppressed due to low confidence (1)
test/e2e/scaffold/adc.go:137
- The removal of the ADC_BACKEND environment variable assignment changes how the ADC backend is configured. Please confirm that this change aligns with the intended design and that ADC receives the correct provider information.
}
AlinsRan
approved these changes
Jun 27, 2025
nic-6443
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
set default provider type as 'apisix'
Pre-submission checklist: