Skip to content

fix(crd): missing shortname and printcolumn#2435

Merged
AlinsRan merged 1 commit intoapache:masterfrom
ronething:fix/crd
Jun 27, 2025
Merged

fix(crd): missing shortname and printcolumn#2435
AlinsRan merged 1 commit intoapache:masterfrom
ronething:fix/crd

Conversation

@ronething
Copy link
Copy Markdown
Contributor

@ronething ronething commented Jun 27, 2025

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething requested a review from Copilot June 27, 2025 07:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses missing shortName and printColumn definitions for various Apisix CRD resources.

  • Adds shortNames for ApisixUpstreams, ApisixRoutes, ApisixPluginConfigs, ApisixGlobalRules, and ApisixConsumers in CRD YAML files.
  • Introduces additional printer columns for ApisixTls and ApisixRoute CRDs.
  • Updates corresponding kubebuilder annotations in the Go type definitions.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/crd/bases/apisix.apache.org_apisixupstreams.yaml Adds shortNames for ApisixUpstream (au).
config/crd/bases/apisix.apache.org_apisixtlses.yaml Adds additional printer columns for ApisixTls but omits a shortNames field.
config/crd/bases/apisix.apache.org_apisixroutes.yaml Adds shortNames (ar) and additional printer columns for ApisixRoute.
config/crd/bases/apisix.apache.org_apisixpluginconfigs.yaml Adds shortNames (apc) for ApisixPluginConfig.
config/crd/bases/apisix.apache.org_apisixglobalrules.yaml Adds shortNames (agr) for ApisixGlobalRule.
config/crd/bases/apisix.apache.org_apisixconsumers.yaml Adds shortNames (ac) for ApisixConsumer.
api/v2/apisixupstream_types.go Introduces shortName via a kubebuilder resource annotation for ApisixUpstream.
api/v2/apisixtls_types.go Updates kubebuilder annotations to include printColumns for ApisixTls.
api/v2/apisixroute_types.go Updates kubebuilder annotations to include shortName and printColumns for ApisixRoute.
api/v2/apisixpluginconfig_types.go Introduces shortName via a kubebuilder resource annotation for ApisixPluginConfig.
api/v2/apisixglobalrule_types.go Introduces shortName via a kubebuilder resource annotation for ApisixGlobalRule.
api/v2/apisixconsumer_types.go Introduces shortName via a kubebuilder resource annotation for ApisixConsumer.
Comments suppressed due to low confidence (1)

config/crd/bases/apisix.apache.org_apisixtlses.yaml:16

  • The ApisixTls CRD in this file includes additionalPrinterColumns but does not define a shortNames field, which is inconsistent with other CRD definitions and the kubebuilder annotation in apisixtls_types.go. Consider adding a shortNames field (e.g., 'shortNames:\n- atls') for consistency.
    singular: apisixtls

@AlinsRan AlinsRan merged commit 16f9d60 into apache:master Jun 27, 2025
21 checks passed
@ronething ronething deleted the fix/crd branch September 13, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants