Skip to content

fix(ci): run e2e group by resource api group#2431

Merged
ronething merged 2 commits intoapache:masterfrom
ronething:fix/ci_sync
Jun 27, 2025
Merged

fix(ci): run e2e group by resource api group#2431
ronething merged 2 commits intoapache:masterfrom
ronething:fix/ci_sync

Conversation

@ronething
Copy link
Copy Markdown
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: ashing <axingfly@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI setup for end-to-end tests by grouping tests using new label filters and enhancing logging output in the ADC executor.

  • Added label filters to Describe blocks in various e2e test files.
  • Updated the Makefile and GitHub workflows to support label filtering.
  • Modified output handling in the ADC executor and removed obsolete RBAC configuration files.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/e2e/* Added Label() to Describe calls to enable filtering by API groups.
internal/provider/adc/executor.go Revised ADC output processing for improved debug logging.
config/rbac/* Removed obsolete RBAC files for gatewayproxy roles.
Makefile & GitHub workflows Updated commands to include label filtering for tests.
test/e2e/gatewayapi/gatewayclass.go Introduced GatewayClass tests (with naming inconsistencies).
Comments suppressed due to low confidence (2)

test/e2e/gatewayapi/gatewayclass.go:35

  • The variable name 'defautlGatewayClass' appears to be misspelled; consider renaming it to 'defaultGatewayClass' for clarity.
		var defautlGatewayClass = `

test/e2e/gatewayapi/gatewayclass.go:48

  • The resource name 'apisix-not-accepeted' seems to have a typo; consider correcting it to 'apisix-not-accepted' to avoid confusion.
  name: apisix-not-accepeted

Comment thread internal/provider/adc/executor.go
@ronething ronething merged commit 03877e0 into apache:master Jun 27, 2025
23 checks passed
@ronething ronething deleted the fix/ci_sync branch June 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants