fix(ci): run e2e group by resource api group#2431
Merged
ronething merged 2 commits intoapache:masterfrom Jun 27, 2025
Merged
Conversation
Signed-off-by: ashing <axingfly@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI setup for end-to-end tests by grouping tests using new label filters and enhancing logging output in the ADC executor.
- Added label filters to Describe blocks in various e2e test files.
- Updated the Makefile and GitHub workflows to support label filtering.
- Modified output handling in the ADC executor and removed obsolete RBAC configuration files.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/* | Added Label() to Describe calls to enable filtering by API groups. |
| internal/provider/adc/executor.go | Revised ADC output processing for improved debug logging. |
| config/rbac/* | Removed obsolete RBAC files for gatewayproxy roles. |
| Makefile & GitHub workflows | Updated commands to include label filtering for tests. |
| test/e2e/gatewayapi/gatewayclass.go | Introduced GatewayClass tests (with naming inconsistencies). |
Comments suppressed due to low confidence (2)
test/e2e/gatewayapi/gatewayclass.go:35
- The variable name 'defautlGatewayClass' appears to be misspelled; consider renaming it to 'defaultGatewayClass' for clarity.
var defautlGatewayClass = `
test/e2e/gatewayapi/gatewayclass.go:48
- The resource name 'apisix-not-accepeted' seems to have a typo; consider correcting it to 'apisix-not-accepted' to avoid confusion.
name: apisix-not-accepeted
dspo
approved these changes
Jun 27, 2025
nic-6443
approved these changes
Jun 27, 2025
AlinsRan
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: