chore: remove useless provider type#2429
Merged
ronething merged 1 commit intoapache:masterfrom Jun 27, 2025
Merged
Conversation
Signed-off-by: ashing <axingfly@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This chore PR removes the unused API7EE provider type and updates related configurations and documentation.
- Removed API7EE constant and branch handling in internal/provider and internal/controller files
- Updated test framework namespace and documentation to align with the removal
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scaffold/adc.go | Removed an obsolete comment |
| test/e2e/framework/framework.go | Updated namespace string from "api7-ee-e2e" to "apisix-e2e" |
| internal/provider/adc/adc.go | Removed the API7EE backend mode case |
| internal/controller/config/types.go | Removed the API7EE provider type constant |
| internal/controller/config/config.go | Changed default provider type from API7EE to Standalone and removed its validation case |
| docs/template/gv_list.tpl | Updated documentation text to remove references to API7 |
| docs/crd/api.md | Updated documentation text to remove references to API7 |
Comments suppressed due to low confidence (3)
internal/provider/adc/adc.go:267
- The removal of the API7EE backend mode branch appears intentional. Please verify that all clients relying on the ADC behavior have been updated to use the supported backend modes to avoid integration issues.
return nil
internal/controller/config/config.go:54
- Since the default provider type has changed from API7EE to Standalone, update the configuration documentation to clearly indicate this change, ensuring users are aware of the supported provider type.
Type: ProviderTypeStandalone,
test/e2e/framework/framework.go:35
- Ensure that the updated namespace 'apisix-e2e' is consistently used across all test configurations and environments to avoid any potential mismatch with existing test setups.
_namespace = "apisix-e2e"
nic-6443
approved these changes
Jun 26, 2025
dspo
approved these changes
Jun 27, 2025
AlinsRan
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: