Skip to content

feat: support apisix provider type and add ingress docs#2427

Merged
ronething merged 4 commits intoapache:masterfrom
ronething:chore/sync_code
Jun 26, 2025
Merged

feat: support apisix provider type and add ingress docs#2427
ronething merged 4 commits intoapache:masterfrom
ronething:chore/sync_code

Conversation

@ronething
Copy link
Copy Markdown
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

update helm chart configmap and role.yaml

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething changed the title chore: update helm charts yaml feat: support apisix provider type and add ingress docs Jun 26, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for an "apisix" provider type and updates various resources such as helm chart configurations, RBAC roles, CRDs, and test workflows to accommodate the new provider mode while also improving ingress documentation.

  • Introduces a new provider type ("apisix") alongside the existing "apisix-standalone".
  • Updates deployment, ADC executor, and CRD configurations to use the new provider type.
  • Adjusts test workflows and manifests (e.g., ingress, role, and CRD definitions) to align with the provider type changes.

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/e2e/scaffold/apisix_deployer.go Replaces the hardcoded service name with a dynamic value based on framework.ProviderType.
test/e2e/framework/assertion.go Modifies the error message format in the API v2 status assertion.
test/e2e/scaffold/adc.go Appends the provider type to ADC environment variables.
test/e2e/gatewayapi/httproute.go Fixes a typo in a comment and replaces sleep with an Eventually-based wait.
config/rbac/role.yaml, config/crd/, charts/, etc. Updates various configurations and manifests to support the new provider mode and related resources.
Comments suppressed due to low confidence (1)

test/e2e/scaffold/apisix_deployer.go:187

  • [nitpick] Ensure that using 'framework.ProviderType' as the default service name is intentional and that it returns a valid service name string in all scenarios. If the service name and provider type are distinct concepts, consider separating these concerns.
		opts.ServiceName = framework.ProviderType

Comment thread test/e2e/framework/assertion.go
@@ -0,0 +1,164 @@
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted.

Signed-off-by: ashing <axingfly@gmail.com>
@ronething ronething requested a review from AlinsRan June 26, 2025 07:28
@ronething ronething merged commit cfa8fd5 into apache:master Jun 26, 2025
21 checks passed
@ronething ronething deleted the chore/sync_code branch June 26, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants