feat: support apisix provider type and add ingress docs#2427
Merged
ronething merged 4 commits intoapache:masterfrom Jun 26, 2025
Merged
feat: support apisix provider type and add ingress docs#2427ronething merged 4 commits intoapache:masterfrom
ronething merged 4 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an "apisix" provider type and updates various resources such as helm chart configurations, RBAC roles, CRDs, and test workflows to accommodate the new provider mode while also improving ingress documentation.
- Introduces a new provider type ("apisix") alongside the existing "apisix-standalone".
- Updates deployment, ADC executor, and CRD configurations to use the new provider type.
- Adjusts test workflows and manifests (e.g., ingress, role, and CRD definitions) to align with the provider type changes.
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scaffold/apisix_deployer.go | Replaces the hardcoded service name with a dynamic value based on framework.ProviderType. |
| test/e2e/framework/assertion.go | Modifies the error message format in the API v2 status assertion. |
| test/e2e/scaffold/adc.go | Appends the provider type to ADC environment variables. |
| test/e2e/gatewayapi/httproute.go | Fixes a typo in a comment and replaces sleep with an Eventually-based wait. |
| config/rbac/role.yaml, config/crd/, charts/, etc. | Updates various configurations and manifests to support the new provider mode and related resources. |
Comments suppressed due to low confidence (1)
test/e2e/scaffold/apisix_deployer.go:187
- [nitpick] Ensure that using 'framework.ProviderType' as the default service name is intentional and that it returns a valid service name string in all scenarios. If the service name and provider type are distinct concepts, consider separating these concerns.
opts.ServiceName = framework.ProviderType
dspo
approved these changes
Jun 26, 2025
nic-6443
approved these changes
Jun 26, 2025
AlinsRan
reviewed
Jun 26, 2025
| @@ -0,0 +1,164 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
AlinsRan
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
update helm chart configmap and role.yaml
Pre-submission checklist: