feat: allow custom labels via Values.podLabels#965
Open
pavankumar-go wants to merge 2 commits intoapache:masterfrom
Open
feat: allow custom labels via Values.podLabels#965pavankumar-go wants to merge 2 commits intoapache:masterfrom
pavankumar-go wants to merge 2 commits intoapache:masterfrom
Conversation
Author
|
@nic-6443 @Baoyuantop Could you spare a little time to review this? It's a small change. |
nic-6443
approved these changes
Apr 25, 2026
Member
nic-6443
left a comment
nic-6443
left a comment
There was a problem hiding this comment.
LGTM. Clean implementation — follows existing patterns, only one pod template to update, values and docs are consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to inject custom labels into the pod template via the podLabels value. This is useful for users who need to add metadata for monitoring, cost allocation, or third-party integrations (e.g., Grafana, Datadog) specifically at the pod level