add support to override the container name#964
Draft
ksdpmx wants to merge 1 commit intoapache:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
apisix.namefor the APISIX container name indeployment.yaml.Why
The container name was using
.Chart.Namedirectly, while other chart-generated names already rely on the sharedapisix.namehelper. This caused inconsistent naming behavior when chart naming is customized.Using the shared helper keeps the Deployment aligned with the rest of the chart and ensures the container name follows the same naming path as other generated resources, especially when
nameOverrideis used.This is also useful when the APISIX chart is consumed as a dependency from another chart and chart naming is customized through overrides or aliases, e.g.
apisixControlPlane,apisixDataPlane. However, the rendered container name still needs to remain a valid lowercase RFC 1123 label.Impact