feat: support webhook server for ingress#888
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds admission webhook functionality to the APISIX ingress controller Helm chart, enabling validation of various Kubernetes resources including ingress-related configurations and Gateway API resources.
- Adds webhook configuration with support for auto-generated or user-provided TLS certificates
- Configures ValidatingWebhookConfiguration for multiple resource types (ApisixRoute, Consumer, Gateway, HTTPRoute, etc.)
- Updates deployment to expose webhook port and mount certificate volumes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| values.yaml | Adds webhook configuration section with certificate and server settings |
| templates/webhook.yaml | New template defining ValidatingWebhookConfiguration, Service, and Secret resources |
| templates/deployment.yaml | Updates container ports and volume mounts for webhook certificates |
| templates/configmap.yaml | Adds webhook configuration to the application config |
| templates/cluster_role.yaml | Reorganizes RBAC permissions for Gateway API resources |
| templates/_helpers.tpl | Adds helper functions for webhook service and secret naming |
| README.md | Documents new webhook configuration parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlinsRan
approved these changes
Oct 17, 2025
Revolyssup
approved these changes
Oct 17, 2025
Signed-off-by: Ashing Zheng <axingfly@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Example:
Debug generated ingress-related configurations: