feat: add more config for gatewayproxy#885
Conversation
|
Hi @AlinsRan and team! 👋 First, thank you for this excellent fix! This addresses a critical security issue we've been experiencing in our production environment. Our Current SituationWe're currently using APISIX Helm chart version 2.12.1 and encountering the exact issue this PR fixes. When we configure the GatewayProxy to use secret-based authentication, the generated resource includes both the hardcoded admin key and our secret reference: apiVersion: apisix.apache.org/v1alpha1
kind: GatewayProxy
spec:
provider:
controlPlane:
auth:
adminKey:
value: edd1c9f034335f136f87ad84b625c8f1 # ❌ Hardcoded default
valueFrom:
secretKeyRef:
key: ADMIN_KEY
name: apisix-privateThis creates security concerns as the hardcoded admin key appears alongside our intended secret-based authentication. Our ConfigurationgatewayProxy:
provider:
controlPlane:
auth:
type: AdminKey
adminKey:
valueFrom:
secretKeyRef:
name: apisix-private
key: ADMIN_KEYQuestions
ImpactThis issue affects anyone using secret-based authentication for GatewayProxy in production environments, as it exposes hardcoded credentials alongside the intended secret references. Thank you again for addressing this issue! Looking forward to the official release. 🙏 Environment Details:
|
|
@vichaos Thank you for your feedback. The next version is expected to be released in a few days. |
https://github.com/apache/apisix-ingress-controller/blob/master/config/crd/bases/apisix.apache.org_gatewayproxies.yaml
valueFrompluginMetatada/plugins