docs: clarify enableThinking example comment#1394
Open
JGoP-L wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies a misleading example comment in the DashScope thinking-mode docs so it reflects both behaviors (enabling thinking and the implicit streaming activation) implemented in DashScopeChatModel.
Changes:
- Update Chinese docs comment from "自动启用流式输出" to "启用思考模式，并自动启用流式输出".
- Apply the same clarification to the English docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/zh/task/model.md | Clarifies enableThinking(true) example comment in Chinese docs. |
| docs/en/task/model.md | Mirrors the clarification in English docs. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.13-SNAPSHOT
Description
Fixes #1393.
Background
The DashScope thinking mode example comment described
.enableThinking(true)only as automatically enabling streaming. This was incomplete because the primary behavior is enabling thinking mode, while streaming is also enabled implicitly by the current implementation.Changes
.enableThinking(true).How to test
Verified the updated comments in:
No Java tests were run because this is a docs-only comment change.
Checklist
Please check the following items before code is ready to be reviewed.